feat(home view): add icons to navigation pills #11528
Merged
+78
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
anandaroop
force-pushed
the
anandaroop/ONYX-1484-quick-links-icons
branch
from
e4a978c to
9b76941
Compare
anandaroop
commented
Feb 11, 2025
Comment on lines
190
to
194
| const SUPPORTED_ICONS: Record<string, ComponentType> = { | ||
| FollowArtistIcon, | ||
| AuctionIcon, | ||
| HeartIcon, | ||
| } |
There was a problem hiding this comment.
We may want to launch with a larger set of icons supported right at the outset.
src/app/Scenes/HomeView/Sections/HomeViewSectionNavigationPills.tsx
Outdated
Show resolved
Hide resolved
dariakoko
reviewed
Feb 11, 2025
src/app/Scenes/HomeView/Sections/HomeViewSectionNavigationPills.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
anandaroop
force-pushed
the
anandaroop/ONYX-1484-quick-links-icons
branch
from
9b76941 to
cdc4852
Compare
dariakoko
previously approved these changes
Feb 19, 2025
src/app/Scenes/HomeView/Sections/HomeViewSectionNavigationPills.tsx
Outdated
Show resolved
Hide resolved
src/app/Scenes/HomeView/Sections/HomeViewSectionNavigationPills.tsx
Outdated
Show resolved
Hide resolved
anandaroop
dismissed stale reviews from dariakoko and MounirDhahri
via
e6fcc1c
anandaroop
force-pushed
the
anandaroop/ONYX-1484-quick-links-icons
branch
2 times, most recently
from
e6fcc1c to
d5642b5
Compare
anandaroop
commented
Feb 19, 2025
There was a problem hiding this comment.
To recap:
Icon naming:
- We decided that the simplest way to anticipate the icon refactor is to start using the standard icon naming from
artsy/icons - The work to make
palette-mobileconform to that naming is ticketed in ONYX-1550- This PR adopts that naming convention already by renaming a couple of icons on import (see comment below); so there is no big rush on ONYX-1550
- I've decided to keep things simple here by not trying to add a layer of abstraction for icon intent, or trying to exhaustively anticipate future name changes for icons. That all seems a little YAGNI to me. If anyone strongly disagrees, we can revisit!
Pill content:
- Due to some miscommunication, the initial round of MP work on pills returns incorrect data
- That work will be corrected in MP next ONYX-1554
- (I hard-coded the corrected data for the sake of the screenshots above, so that's what everyone can expect to see soon)
Comment on lines
+3
to
+4
| ArtworkIcon, | ||
| AuctionIcon as GavelIcon, |
There was a problem hiding this comment.
| @@ -57,6 +72,7 @@ export const HomeViewSectionNavigationPills: React.FC<HomeViewSectionNavigationP | |||
| accessibilityRole="link" | |||
| testID={`pill-${pill.title}`} | |||
| variant="link" | |||
| Icon={SUPPORTED_ICONS[pill.icon as string]} | |||
There was a problem hiding this comment.
Thanks to the realization that Pill already supports an Icon prop, the implementation here is greatly simplified. Basically just this line and the SUPPORTED_ICONS mapping below on L191.
anandaroop
force-pushed
the
anandaroop/ONYX-1484-quick-links-icons
branch
from
d5642b5 to
945666e
Compare
|
Rebasing and merging now… |
anandaroop
added
the
Squash On Green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1464
Description
Consumes the new
iconfield of theNavigationPillMP type in order to render icons in the Quick Links section of the home view.Unsupported or missing icons are simply not rendered.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.