Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity lookup improvements + test fix #1679

Merged
merged 9 commits into from
Jun 22, 2022
Merged

Identity lookup improvements + test fix #1679

merged 9 commits into from
Jun 22, 2022

Conversation

marcinbudny
Copy link
Contributor

Description

  • Wait for the partition identity lookup to stop when calling Cluster.ShutdownAsync()
  • Fix a problem with shutdown process hanging when using PartitionIdentityLookup with mode = Pull
  • Fixes for the partition identity test and include it in CI

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@marcinbudny marcinbudny requested a review from rogeralsing June 21, 2022 10:58
@rogeralsing rogeralsing merged commit 083f8c3 into asynkron:dev Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeralsing rogeralsing rogeralsing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinbudny @rogeralsing @marcinbudny-etteplan