Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protobuf to 29.3 (bzlmod only) #1314

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Update protobuf to 29.3 (bzlmod only) #1314

merged 1 commit into from
Feb 6, 2025

Conversation

joca-bt
Copy link
Contributor

@joca-bt joca-bt commented Jan 19, 2025

No description provided.

@joca-bt joca-bt marked this pull request as ready for review January 19, 2025 17:07
@joca-bt joca-bt mentioned this pull request Jan 19, 2025
Open
shs96c
shs96c approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the comment explaining why we're leaving the workspace-based build alone!

@shs96c shs96c merged commit 0b5d9da into bazel-contrib:master Feb 6, 2025
7 checks passed
@renovate renovate bot mentioned this pull request Feb 11, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

@jin jin Awaiting requested review from jin jin is a code owner

@cheister cheister Awaiting requested review from cheister cheister is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joca-bt @shs96c