Skip to content

Incorrect handling of GB alpha2 codes for main countries #73

Open
@joh-ku

Description

When searching for countries.ByName("scotland") the return value is GB.

For Scotland the correct ISO-3166-2 code should be GB-SCT instead. Same applies for all other main countries in UK, which don't have a parent subdivision.

Those are:

  1. England -> GB-ENG
  2. Northern Ireland -> GB-NIR
  3. Scotland -> GB-SCT
  4. Wales -> GB-WLS

See https://www.iso.org/obp/ui/#iso:code:3166:GB.

I'm happy to provide a PR, if the change is accepted.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions