Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nil predicates, matching all nodes #4

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Allow nil predicates, matching all nodes #4

merged 1 commit into from
Jan 14, 2025

Conversation

bobg
Copy link
Owner

@bobg bobg commented Jan 14, 2025

This PR adds the ability to specify nil as the value for any node predicate. It's equivalent to specifying

func (*html.Node) bool { return true }

Copy link

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR does not require a change in your module’s version number.
(You might still consider bumping the patchlevel anyway.)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12771077926

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.385%

Totals Coverage Status
Change from base Build 12741303877: 0.0%
Covered Lines: 196
Relevant Lines: 260

💛 - Coveralls

@bobg bobg merged commit a5875db into master Jan 14, 2025
1 check passed
@bobg bobg deleted the bobg/nil-pred branch January 14, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants