new lang tag, chinese + russian lang generators #97
Conversation
|
Hi @musinit, Would you mind do a linter checking first? # Downloading the linter
$ make lint-prepare
# Apply the linter
$ make lint |
|
Sure! |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 94.92% 95.04% +0.11%
==========================================
Files 10 10
Lines 966 989 +23
==========================================
+ Hits 917 940 +23
Misses 27 27
Partials 22 22
Continue to review full report at Codecov.
|
|
@bxcodec how is this PR for you? If all in all it's ok as an idea and realisation, I will cover it with more tests to pass all checks. |
|
Overall looks good. I'm not sure yet about the correctness, but yeah it's just a random word, same with the English character, we just put a random chars on it, so I'm good. Please add more coverage if possible 🙏 |
|
Yeh, sure! |
|
Don't understand, what means codecov/patch — 91.83% of diff hit (target 94.92%)..hope someone will help me to understand what should I change (more test coverage?) |
| if err != nil { | ||
| return nil, fmt.Errorf(ErrWrongFormattedTag, tag) | ||
| } | ||
| strlen, _ = strconv.Atoi(lenParts[1]) |
There was a problem hiding this comment.
in this concrete case lenParts[1] are always some digits, because of the regex len=\d+. But if you think that we should check error anyway, because, for example, someone can change this regex, or smth else can happen, I'll do it
It's okay, I think it affected by previous code. |
I thought it would be nice to check string encoding, if you have possibility to generate strings in different languages.
fix #94