Experimental support of EnqueueTrial. #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed an Optuna's concurrency problem at optuna/optuna#1014. |
c-bata
changed the title
c-bata
changed the title
c-bata
commented
Mar 11, 2020
Comment on lines
+508
to
+520
| // TODO(c-bata): Add `FOR UPDATE` clause. | ||
| // | ||
| // result := tx.Set("gorm:query_option", "FOR UPDATE"). | ||
| // First(&trial, "trial_id = ?", trialID) | ||
| // | ||
| // But SQLite3 doesn't interpret `FOR UPDATE` clause. | ||
| // SQLAlchemy can automatically remove it, but Gorm can't. | ||
| // | ||
| // Another solution is to add `EnableForUpdateClause=false` option. | ||
| // | ||
| // See following pages for the information. | ||
| // * https://github.com/optuna/optuna/pull/1014 | ||
| // * http://gorm.io/docs/query.html#Extra-Querying-option |
There was a problem hiding this comment.
[memo] Put a todo comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs optuna/optuna#520.
to close #45.