Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: inventory skew #1402

Merged
merged 3 commits into from
Jan 6, 2024
Merged

FEATURE: inventory skew #1402

merged 3 commits into from
Jan 6, 2024

Conversation

narumiruna
Copy link
Collaborator

No description provided.

@narumiruna narumiruna requested a review from c9s November 8, 2023 10:00
@bbgokarma-bot
Copy link

Welcome back! @narumiruna, This pull request may get 275 BBG.

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from eea7382 to fce4306 Compare November 8, 2023 10:23
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 280 BBG

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from fce4306 to f6dd644 Compare November 8, 2023 10:33
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 285 BBG

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (7f8a331) 21.33% compared to head (7f0a4a9) 21.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   21.33%   21.28%   -0.06%     
==========================================
  Files         591      593       +2     
  Lines       43465    43662     +197     
==========================================
+ Hits         9274     9293      +19     
- Misses      33516    33694     +178     
  Partials      675      675
Files Coverage Δ
pkg/strategy/fixedmaker/inventory_skew.go 68.00% <68.00%> (ø)
pkg/strategy/fixedmaker/strategy.go 1.28% <0.00%> (ø)
pkg/strategy/xfixedmaker/strategy.go 1.05% <0.00%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8a331...7f0a4a9. Read the comment docs.

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from f6dd644 to 4a7e142 Compare November 13, 2023 07:58
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 302 BBG

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from 4a7e142 to 28b5f48 Compare November 13, 2023 08:16
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 343 BBG

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from 28b5f48 to ac405d9 Compare November 13, 2023 09:04
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 392 BBG

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from ac405d9 to ea98c7f Compare November 13, 2023 09:07
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 399 BBG

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from ea98c7f to 38db4d3 Compare November 13, 2023 09:39
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 392 BBG

@c9s
Copy link
Owner

c9s commented Dec 20, 2023

@narumiruna 這隻可以先進？我們之後再調整 API ~~

@narumiruna
Copy link
Collaborator Author

@narumiruna 這隻可以先進？我們之後再調整 API ~~

好

@narumiruna narumiruna marked this pull request as ready for review December 21, 2023 08:03
@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from 38db4d3 to 8ecba43 Compare December 21, 2023 08:03
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 407 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 499 BBG

@narumiruna narumiruna force-pushed the narumi/fixedmaker/inventory-skew branch from 96eada2 to 7f0a4a9 Compare December 21, 2023 08:39
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 504 BBG

@c9s
Copy link
Owner

c9s commented Jan 3, 2024

@narumiruna 要進了嗎

@narumiruna
Copy link
Collaborator Author

@narumiruna 要進了嗎

go

@narumiruna narumiruna merged commit 6367bd7 into main Jan 6, 2024
3 of 4 checks passed
@narumiruna narumiruna deleted the narumi/fixedmaker/inventory-skew branch January 6, 2024 09:00
@bbgokarma-bot
Copy link

Hi @narumiruna,

Well done! 519 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x268968aa4251deed48a120b6d7d7f664a6e1ae9385403fc106a435c54a95a9aa

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narumiruna @bbgokarma-bot @c9s