-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: [bollmaker] add emaCross signal #1463
Conversation
Welcome back! @c9s, This pull request may get 248 BBG. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 21.33% 21.32% -0.01%
==========================================
Files 591 591
Lines 43471 43486 +15
==========================================
Hits 9274 9274
- Misses 33522 33537 +15
Partials 675 675
Continue to review full report in Codecov by Sentry.
|
@@ -435,14 +445,20 @@ func (s *Strategy) placeOrders(ctx context.Context, midPrice fixedpoint.Value, k | |||
} | |||
} | |||
|
|||
if !s.shouldBuy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not shouldBuy != Should not buy
Maybe rename this variable to shouldNotBuy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldBy is set to true by default, would like to keep it simple to not to put a reversed logic in the variable ^^||
Re-estimated karma: this pull request may get 285 BBG |
Hi @c9s, Well done! 290 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x31768629f5d8e4b4cb420fde1777a58f4c8710b5cf792e99afa4be31c86f5b04 Thank you for your contribution! |
No description provided.