pkg/exchange: update query open orders to latest #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bailantaotao
commented
Oct 15, 2024
bailantaotao
commented
- We specified the quantity for the market buy order as the base coin when we submitted the order, so we can just use the Qty field.
- Market orders use AvgPrice as types.Order.Price.
bailantaotao
requested review from
c9s,
ycdesu,
kbearXD,
gx578007 and
narumiruna
|
Welcome back! @bailantaotao, This pull request may get 216 BBG. |
Base automatically changed from
edwin/bybit/query-wallet-bal
to
edwin/bybit/uta
October 15, 2024 04:00
bailantaotao
force-pushed
the
edwin/bybit/query-open-orders
branch
from
5c53788 to
b41cd34
Compare
|
Re-estimated karma: this pull request may get 251 BBG |
c9s
approved these changes
Oct 15, 2024
|
Hi @bailantaotao, Well done! 256 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x458258fa6b3ba4625b855aeea5398ddbce0bb78dd6b2ccb0f7052ed355c2250e Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.