Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: If futures order is Market order use avg price replace zero price #1853

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

anywhy
Copy link
Contributor

@anywhy anywhy commented Dec 5, 2024

No description provided.

@bbgokarma-bot
Copy link

Hi @anywhy,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 210 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@anywhy anywhy changed the title [Fix]: If futures order is Market order use avg price replace zero price FIX: If futures order is Market order use avg price replace zero price Dec 5, 2024
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 215 BBG

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 23.24%. Comparing base (4d83110) to head (6ff6f85).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
pkg/exchange/binance/convert_futures.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
+ Coverage   23.14%   23.24%   +0.09%     
==========================================
  Files         636      637       +1     
  Lines       48268    48459     +191     
==========================================
+ Hits        11174    11262      +88     
- Misses      36285    36373      +88     
- Partials      809      824      +15     
Files with missing lines Coverage Δ
pkg/exchange/binance/convert_futures.go 5.74% <0.00%> (-0.12%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884fdb9...6ff6f85. Read the comment docs.

@c9s c9s merged commit 215e5b1 into c9s:main Dec 6, 2024
4 of 5 checks passed
@anywhy anywhy deleted the fix_binance_futures_order_price branch February 12, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants