[FEATURE]: support binance futures orderbook depth buffer #1902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
==========================================
- Coverage 23.40% 23.22% -0.18%
==========================================
Files 648 657 +9
Lines 49010 49528 +518
==========================================
+ Hits 11469 11504 +35
- Misses 36693 37173 +480
- Partials 848 851 +3
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pkg/depth/buffer.go
Outdated
| // skip old events | ||
| if u.FinalUpdateID <= finalUpdateID { | ||
| continue | ||
| if b.isFutures { |
There was a problem hiding this comment.
what's the difference between futures and non-futures?
pkg/depth/buffer.go
Outdated
| } | ||
| if u.FirstUpdateID <= finalUpdateID && u.FinalUpdateID >= finalUpdateID { | ||
| pushUpdates = append(pushUpdates, u) | ||
| } |
There was a problem hiding this comment.
I think this logic is the same as non-futures? it's just reversed ?
There was a problem hiding this comment.
And the field PreviousUpdateID is not used here?
There was a problem hiding this comment.
I see, it's indeed the same logic. I'll merge it.
anywhy
force-pushed
the
futures_depth_buffer
branch
from
2691d3d to
6b709e5
Compare
No description provided.