Options to set defaults for zero values only #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnovikoff
force-pushed
the
set_default_for_zero_only
branch
4 times, most recently
from
6bb7931 to
d7824e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 626 622 -4
=========================================
- Hits 626 622 -4 ☔ View full report in Codecov by Sentry. |
dnovikoff
force-pushed
the
set_default_for_zero_only
branch
2 times, most recently
from
eacd4d3 to
4479add
Compare
dnovikoff
force-pushed
the
set_default_for_zero_only
branch
from
4479add to
1d07485
Compare
caarlos0
reviewed
Feb 19, 2025
dnovikoff
force-pushed
the
set_default_for_zero_only
branch
from
1d07485 to
58aa16b
Compare
dnovikoff
force-pushed
the
set_default_for_zero_only
branch
from
58aa16b to
e8b732f
Compare
I've added the example. Please check that it fits |
|
looks good, thanks @dnovikoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered scenarious of loading config from file and then applying env vars.
Would be nice to ignore defaults for thouse values already set.