Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - CefDragHandler #673

Merged
merged 26 commits into from
Dec 8, 2014
Merged

Conversation

amaitland
Copy link
Member

Implement basic CefDragHandler support, it's not a fully complete implementation.

Also note there's a number of files that have been deleted that are unrelated to this PR (they're just cleanup that I found along the way).

Update
Incomplete parts related to

  • GetFileContents
  • GetFileNames (which I believe is a pointer to a vector, so I'm guessing it should be possible to remove a filename from the list)

daveaton and others added 24 commits December 8, 2014 20:55
Trying to learn how to Implement a feature for Dragging  Objects into
CefSharp
The project will build now..  got to figure out what's needed for
DragData.cs and DragOperationsMask.cs
Spacing corrections
Completed DragData.cs and DragOperationsMask.cs

When you return true from OnDragEnter I was expecting to cancel all
requests  But if you Drag an image from one url to another it still does
not prevent this from happening.. more research is needed.
Maybe I am over thinking it ... It probably should be handled like this.

http://www.eatoncode.com/shareit/2014-11-28_2031.png

but I still got an issue.
It appears that I  did not need to include the cef_drag_handler.h file,
seems to work fine without it.
Need to figure out why DataClass is not accepted
Re-add DragOperationsMask
Apply flags attribute and implement `Every` option
…eamWriter wrapper before this method can be implemented)
@amaitland amaitland added enhancement winforms wpf WPF Implementation labels Dec 8, 2014
@amaitland amaitland added this to the 37.0.0 milestone Dec 8, 2014
@amaitland
Copy link
Member Author

There are a few whitespace/cleanup fixes still required now that I'm looking at the "Files Changed", I'll fix those a bit later, I've done enough for tonight.

amaitland added a commit that referenced this pull request Dec 8, 2014
@amaitland amaitland merged commit ded432c into cefsharp:master Dec 8, 2014
@amaitland amaitland deleted the feature/draghandler branch December 8, 2014 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants