-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change c++ file copyright symbol (©) encoding to work on non-english system #731
Conversation
…p65001 without bom) , now work on non-english system().
Should they be with or without BOM? I think the default for |
@amaitland Yes, you are right, I missing the BOM.sorry. |
…2 0xa9(cp65001 without bom) ," This reverts commit defd040.
…p65001 with bom) , now work on non-english system().
Thanks 👍 I'll try to merge this next week |
@binsys Merging this now. I've looked at a random sample and everything looks ok 👍 It maybe a little bit of an uphill battle as it's likely new files added will be |
change c++ file copyright symbol (©) encoding to work on non-english system
Maybe it can be added as some kind of a linting step to the build, together with spaces vs tabs? Let's see how much of a stumbling block it will be? |
Some sort of pre-commit hook that does some housekeeping would be handy 👍 |
@amaitland |
@binsys How much of a problem does the Also were you looking to add the plugin functions? |
change c++ file copyright symbol (©) encoding from 0xa9(cp1252) to 0xc2 0xa9(cp65001 with bom) ,
now work on non-english system.
Note:* .cs files encoded correct, do not need changes.