Implement CefGeolocationHandler::OnRequestGeolocationPermission

[pushplay]

delegating the request to a CefSharp.IGeolocationHandler implementation. This allows CefSharp to permit geolocation requests.

This implements #332 .

[pushplay]

Geolocation requests with the option {enableHighAccuracy: false} work as expected. A call to the google api domain is made which fails if the google api key isn't set. There's information about setting the google api key here: http://www.chromium.org/developers/how-tos/api-keys . I can add a wiki entry on the subject once (if?) the PR is accepted.

I haven't yet confirmed {enableHighAccuracy: true} working as expected on a device with GPS as I don't have one available to test with. I might be able to get one in the future.

[amaitland]

I can add a wiki entry on the subject once (if?) the PR is accepted.

@pushplay Looks great, let's merge this before the 39 release 👍 A wiki entry would be great 👍

[amaitland]

Brace on new line please 👍

[pushplay]

@amaitland done 👍

[amaitland]

Thanks, will take it for a spin when I get a chance 👍

[jornh]

@pushplay excellent looking (first?) PR, 👍 really happy to have people doing stuff like that in the community 😄

[pushplay]

It was totally selfish. I needed it to work, so I did it. :)

[jornh]

😄 I like that kind of selfishness

[jankurianski]

I was able to get this going in so far as seeing my CefSharp geolocation API requests showing as 4xx client errors in the Google dev console... looks like I have to "contact sales" to get actual quota for that API 😄

• I think you could add this as a commented-out part of CefExample.Init() to show how to set the keys:

// Set Google API keys, used for Geolocation requests.  See http://www.chromium.org/developers/how-tos/api-keys
// Environment.SetEnvironmentVariable("GOOGLE_API_KEY", "");
// Environment.SetEnvironmentVariable("GOOGLE_DEFAULT_CLIENT_ID", "");
// Environment.SetEnvironmentVariable("GOOGLE_DEFAULT_CLIENT_SECRET", "");

• The example GeolocationHandler permission message could have a reference to setting API keys in CefExample.Init(), that way it is self-documenting. For example,

  {0} wants to use your computer's location. Allow?
  ** You must set your Google API key in CefExample.Init() for this to work. **

• Is there any reason to have 2 separate copies of GeolocationHandler.cs instead of 1 in the CefSharp.Example project?

[jankurianski]

BTW, really good PR! 👍

[amaitland]

I think you could add this as a commented-out part of CefExample.Init() to show how to set the keys:

Nice touch, I like it 👍

Is there any reason to have 2 separate copies of GeolocationHandler.cs instead of 1 in the CefSharp.Example project?

Can you use the WinForms messagebox from a WPF app? Can't say that I've ever tried it.

[pushplay]

Can you use the WinForms messagebox from a WPF app?

I haven't used UI elements from both in a project, but I have had references to both in a project and it leads to some confusing Intellisense results.

[jankurianski]

Sorry, I misread the WPF GeolocationHandler as using the WinForms MessageBox already. Disregard that point 🙊 😄

[amaitland]

@pushplay Do you mind making the first two changes @jankurianski suggested? After that I think this can be merged 👍

[pushplay]

@amaitland Sure I'll look into it tomorrow.

[amaitland]

@pushplay Fantastic thanks! 👍

@jankurianski When your happy feel free to test out that shiny new merge button 😄

[jankurianski]

Thanks a lot for your contribution @pushplay 👍
Also added your feature to the ChangeLog for the 39 release.

[amaitland]

@pushplay Greatly appreciated 😄

@jankurianski excellent suggestions 👍