Javascript Callbacks - Take 2 #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e,changed field names according to conventions
…rit from DisposableResource
…feature/jsb-callback
Also check if channel state is Opened before trying to release callback
… Deregister for javascript callback
This reverts commit 746e514.
…dPointBehaviour` I think it's easier just to pass around a WeakReference
|
Still need to add some documentation about the If anyone has time to look over this once more before merging that would be greatly appreciated 😄 |
Merged
|
I haven't given this a try, but the code looks fine to me. |
…ugh to give at least the basic idea of how it fits together
amaitland
added a commit
that referenced
this pull request
Mar 19, 2015
Javascript Callbacks - Take 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #868
Includes additional changes
ConcurrentDictionaryWeakReferencerather than the process host it's self