Backport streamlined NaiveDate
unit tests
#1500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set replaces tuples with an
Option<NaiveDate>
in some unit tests. This results in a less clutteredcheck
function and keeps the code more in sync with the0.5.x
branch, whereResult<NaiveDate, Error>
will be more prevalent.Initially suggested by @pitdicker in #1475 for
checked_(add/sub)_days
and extended on two more unit tests, which will likely be adapted in0.5.x
shortly.Affected unit tests:
checked_add_days
checked_sub_days
test_date_sub
→test_date_signed_duration_since
test_date_add
→test_date_checked_add_signed