Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove the extra log prefix #797

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

hiahia12
Copy link
Contributor

@hiahia12 hiahia12 commented May 29, 2023

What type of PR is this?

style

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

移除了多余的日志前缀

(Optional) More detail description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR

fixes #794

(Optional) The PR that updates user documentation:

@hiahia12 hiahia12 requested review from a team as code owners May 29, 2023 08:36
@hiahia12
Copy link
Contributor Author

微信图片_20230529164033

@FGYFFFF
Copy link
Contributor

FGYFFFF commented May 29, 2023

可以提供一下前后日志对比吗? hertz 框架内打的日志,都需要有 "HERTZ: " 前缀

@hiahia12
Copy link
Contributor Author

241177840-c0d60147-b86a-41d4-aece-63acf9b99068
之前出现了两个HERTZ:

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@welkeyever welkeyever changed the title style:remove the log prefix style: remove the extra log prefix May 29, 2023
@welkeyever welkeyever merged commit cdcafeb into cloudwego:develop May 29, 2023
@xyu-io
Copy link

xyu-io commented May 29, 2023

Many hands make light work, thank you for your efforts.

Skyenought pushed a commit to Skyenought/hertz that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary log prefix. Procedure
5 participants