fix: poller read all data before connection close #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 62 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 55 | 1 | 6 | 0 |
Click to see the invalid file list
- poll_default.go
joway
force-pushed
the
fix/server-close-v2
branch
from
e53117c to
d62c74c
Compare
joway
force-pushed
the
fix/server-close-v2
branch
5 times, most recently
from
6c01ce3 to
19c7ede
Compare
joway
force-pushed
the
fix/server-close-v2
branch
2 times, most recently
from
de9a7be to
acd5e1b
Compare
joway
force-pushed
the
fix/server-close-v2
branch
2 times, most recently
from
00f72a0 to
2206ca1
Compare
joway
force-pushed
the
fix/server-close-v2
branch
from
2206ca1 to
2f0b6ef
Compare
jayantxie
reviewed
Feb 28, 2023
ppzqh
reviewed
Feb 28, 2023
joway
force-pushed
the
fix/server-close-v2
branch
from
ac03b08 to
068f951
Compare
joway
force-pushed
the
fix/server-close-v2
branch
from
068f951 to
abf20c6
Compare
ppzqh
approved these changes
Mar 1, 2023
ppzqh
approved these changes
Mar 1, 2023
jayantxie
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
chore
What this PR does / why we need it (en: English/zh: Chinese):
en: fix: poller read all data before connection close
zh: fix: poller 在连接关闭之前，尝试读取完所有数据
Which issue(s) this PR fixes: