-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barcodes you can use backgrounds with. #295
Conversation
ok .. this may be good enough.. tell me what you think . |
We could put back support for the 'overlay image' aswell. I took it out for now. |
Hi @NigelThorne thanks for your work and the pull request. I'll review within the next days. One thing I already have in mind: Would you mind, if I rename it from "LogoQRCode" to "ArtQRCode"? Background: I think "Logo" may a bit misleading, because users can already place logos on other QRCode rendering classes. Art (or Artistic) would better describe the type of rendering in my opinion. |
sounds good. |
I've fixed the behaviour so the pixels get cropped to the module square size. This has the side effect that if you set the pixel size large enough you get a standard barcode. |
Hi!
? |
@AlexandreZaytsev You can pass custom images to use as the corners. They have to be something that would scan though.. :) so they need to have the same 'ring' type structure with the right thickness of black and white. Google use this |
@codebude Any plans to merge this :) |
@AlexandreZaytsev If you make the background transparent you can put the background in with a paint package. This lets you cheat and remove dots where faces are etc and still get something that scans (due to the error correcting nature of qr) |
Summary
Generate barcodes that can have background images and custom retackle images in the corners.
Test plan
Try it out. :)
Closing issues
closes #294