Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate proposal during creation #163

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Validate proposal during creation #163

merged 7 commits into from
Jul 20, 2022

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Jul 20, 2022 •
edited
Loading

Closes #156.

TODO:

  • Check validator voting contract as admin of migrated contract. (done)

@maurolacy maurolacy requested review from hashedone and uint July 20, 2022 07:30
@maurolacy maurolacy self-assigned this Jul 20, 2022
hashedone
hashedone approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurolacy maurolacy merged commit 9dbd508 into main Jul 20, 2022
@maurolacy maurolacy deleted the 156-validate-proposal-during-creation branch July 20, 2022 17:15
@maurolacy maurolacy mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

@uint uint Awaiting requested review from uint

Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tgrade-validator-voting] Add proposal validation during creation
2 participants
@maurolacy @hashedone