Older version migration helper #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
fix/older-version-migration
branch
from
340c50d to
5f5a5ce
Compare
maurolacy
force-pushed
the
fix/older-version-migration
branch
from
5f5a5ce to
db62dc6
Compare
ueco-jb
approved these changes
Jul 26, 2022
I agree. This should be called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
ensure_from_older_version(which could very well be namedupdate_version) return the original contract version for convenience.This is because current migration code usually reads the contract version after calling this function. Which is a bug, as the contract version has already been updated (by this function) at that point.