Fix claims auto-release of vesting amounts #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
fix/auto-release-undelegate
branch
from
041a71a to
192f36b
Compare
maurolacy
force-pushed
the
fix/auto-release-undelegate
branch
from
a7f7ac6 to
9a95f35
Compare
maurolacy
force-pushed
the
fix/auto-release-undelegate
branch
from
9a95f35 to
074e49f
Compare
hashedone
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Overall it's ok. I am unsure about just silencing up good clippys points on production code. Also, it looks like test cases are not unit, but testing flow, including communication with blockchain, which IMHO should be done with MT (I know there is a bit of work to do with custom messages, but for now, we are stockpiling this kind of usages for the sake of "we need to implement it at some point" - we are building up tech debt).
No acceptance because I want to understand the flow and reasoning to verify if logic makes sense. I will do it this evening.
hashedone
approved these changes
Dec 15, 2022
Fix type_complexity warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix claims auto-release of vesting amounts.