Add half-life event member updates #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug shows the limits of unit testing, by the way. Everything is properly unit tested, and still this is wrong, and fails in an integrated environment. |
ethanfrey
reviewed
Jan 24, 2023
Fortunately, they are being ignored on the receiving (mixer) end
maurolacy
force-pushed
the
fix/halflife-member-updates
branch
from
54fd28c to
daf5f26
Compare
ethanfrey
approved these changes
Jan 25, 2023
| if points <= 1 { | ||
| return Ok(None); | ||
| } | ||
| Ok(Some(MemberDiff::new(addr, Some(points), Some(points)))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203.
Opted for straightforward changes for the fix, instead of a full refactoring.
Member.pointsis unsigned, and adding more complexity toupdate_membersdoesn't look like a good idea. In fact, perhaps it would be better to break downupdate_membersintoadd_membersandremove_members(as suggested in the past), and then add a newhalve_membersin parallel.TODO:
Unit tests. (done)Migration handler update member msgs fixing code(done).