Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tg3 package to publishing script #97

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Add tg3 package to publishing script #97

merged 2 commits into from
Feb 9, 2022

Conversation

maurolacy
Copy link
Contributor

No description provided.

@maurolacy maurolacy enabled auto-merge February 9, 2022 18:47
@maurolacy maurolacy merged commit 16e6e04 into main Feb 9, 2022
Copy link

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -3,7 +3,7 @@ set -o errexit -o nounset -o pipefail
command -v shellcheck >/dev/null && shellcheck "$0"

# These are imported by other packages - wait 30 seconds between each as they have linear dependencies
BASE_CRATES="packages/bindings packages/bindings-test packages/tg4 packages/utils contracts/tg4-engagement contracts/tg4-stake contracts/tg4-mixer packages/voting-contract"
BASE_CRATES="packages/bindings packages/bindings-test packages/tg4 packages/utils ontracts/tg4-engagement contracts/tg4-stake contracts/tg4-mixer packages/tg3 packages/voting-contract"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BASE_CRATES="packages/bindings packages/bindings-test packages/tg4 packages/utils ontracts/tg4-engagement contracts/tg4-stake contracts/tg4-mixer packages/tg3 packages/voting-contract"
BASE_CRATES="packages/bindings packages/bindings-test packages/tg4 packages/utils contracts/tg4-engagement contracts/tg4-stake contracts/tg4-mixer packages/tg3 packages/voting-contract"

@maurolacy maurolacy deleted the fix/publish.sh branch February 9, 2022 20:04
@ueco-jb ueco-jb restored the fix/publish.sh branch February 9, 2022 20:04
@ueco-jb
Copy link

ueco-jb commented Feb 9, 2022

Oh, so cocky of you to not wait for review!

EDIT: Haha, I didn't notice auto-merge enabled and as usual I approved with minor comment.

I guess this feature is one of those shoot-in-the-foot ones.

@maurolacy
Copy link
Contributor Author

I see... was pretty sure this was correct. Good eye, will fix the typo in a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants