Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infinite empty loop #483

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Jan 19, 2022

Here removed extra statement with default that avoid expected blocking execution and work as infinite loop.
There is no tests because I don't know how to test removing this statement without overengineering like add more logs, subscribe in tests with new handler and check that logs weren't generated. But this log entry we don't need even with debug level and will produce redundant messages...
So imho, we can just remove this statement and believe that it works better. But maybe someone can suggest some way to test it, I will add it.

Checklist

@Lagovas Lagovas requested review from iamnotacake and Zhaars January 19, 2022 00:33
@Lagovas Lagovas merged commit ff8beae into master Jan 19, 2022
@Lagovas Lagovas deleted the lagovas/acra-censor-remove-infinite-loop branch January 19, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants