Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix import issue about useInsertionEffect on react 17 #1627

Merged
merged 1 commit into from
Jul 31, 2022
Merged

fix import issue about useInsertionEffect on react 17 #1627

merged 1 commit into from
Jul 31, 2022

Conversation

behnammodi
Copy link
Member

Corresponding Issue(s):

#1618

What Would You Like to Add/Fix?

By this PR JSS consumers can use React 17 and 16

Changelog

Fix useInsertionEffect import issue on react 16 and 17

@behnammodi behnammodi requested a review from kof as a code owner July 31, 2022 21:25
@behnammodi behnammodi mentioned this pull request Jul 31, 2022
Closed
kof
kof approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like react has inconsistent bundling for new features if that works

@kof kof merged commit d18561f into cssinjs:master Jul 31, 2022
@kof
Copy link
Member

kof commented Jul 31, 2022

released 10.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behnammodi @kof