-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 compatibility by upgrading to redux v5 and updating peer dependency ranges #942
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @kije ! Thanks for the PR! I'll look through the changes as soon as I get some spare time 👍 I'm guessing the checks are failing due to a legacy node version (14) used by the runners? |
@jmyrland Thanks for triggering the checks. I'll take a look at what the issue is, |
Ok looks like these issues are related to the legacy node version: E.g. with a more current version (v22.13.1) the tests work without issue |
I've released an alpha version of this, so we can test it in our projects to check for issues: |
Let's see if bumping the node version works 🤞 |
Worked like a charm 👌Ignore the vercel check - it's broken (cc @ctrlplusb please fix, or give us access 🙏) I'll do a little testing with this version on my end, and I'll report back when done @kije |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any issues testing this version on my end.
If these changes are good with you @no-stack-dub-sack, I can do a release tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a release of this shortly.
Related issue: #940
This MR makes easy-peasy React 19 compatible. It required an update to
react-redux
version 9.2.Since v9.0 of
react-redux
however, the library requires React 18 or higher and redux 5. Thus, this MR drops support for React versions < 18Note: This MR is only contains the minimal changes to get React 19 compatibility. Futher work like switching to Redux Toolkit (https://redux.js.org/usage/migrating-to-modern-redux) might be desirable as followup work