Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Snyk issues #247

Merged
merged 1 commit into from
May 19, 2023
Merged

Address Snyk issues #247

merged 1 commit into from
May 19, 2023

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented May 18, 2023 •
edited
Loading

Desired Outcome

This pull request addresses the Snyk issues outlined in this repository.

Implemented Changes

  • upgrades Go base image in Dockerfile to 1.20
  • upgrades Go base image in Dockerfile.acceptance to 1.20
  • upgrades golang.org/x/net to v0.10.0
  • upgrades golang.org/x/crypto to v0.9.0
  • upgrades golang.org/x/sys to v0.8.0

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner May 18, 2023 17:22
szh
szh reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs a changelog entry

@juniortaeza juniortaeza force-pushed the snyk-issues-branch branch from ec60048 to 0168f39 Compare May 18, 2023 20:08
@juniortaeza juniortaeza merged commit 3c83a68 into main May 19, 2023
@juniortaeza juniortaeza deleted the snyk-issues-branch branch May 30, 2023 15:58
@gl-johnson gl-johnson mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szh szh szh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juniortaeza @szh