Close stdin before waiting to allow --select-1 to work #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, using the --select-1 option with iterfzf would result in FZF block indefinitely. When stdin is left open, --select-1 would never terminate since FZF anticipates more input and the POpen.wait() call just hangs. By closing stdin before making the call to POpen.wait(), FZF is only waiting on user input (if any is required) and not blocking for any other reason. This patch also includes a very rudimentary unit test suite that can be run with `python -m unittest`. The suite requires the user to press the enter key. Presumably there is a way to use unittest.mock to patch stdin and replace it with a defined string so that the test suite can run without manual intervention, but the complexities of that operation eluded me. My working theory is that it will be necessary to use the pty module to control terminal operations programmatically, but that is beyond my level of expertise.
dahlia
approved these changes
Mar 6, 2024
|
Thnaks for your contribution! |
dahlia
added a commit
that referenced
this pull request
Mar 6, 2024
dahlia
added a commit
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, using the
--select-1option with iterfzf would result in FZF block indefinitely. When stdin is left open,--select-1would never terminate since FZF anticipates more input and thePOpen.wait()call just hangs. By closing stdin before making the call toPOpen.wait(), FZF is only waiting on user input (if any is required) and not blocking for any other reason.This patch also includes a very rudimentary unit test suite that can be run with
python -m unittest. The suite requires the user to press the enter key. Presumably there is a way to use unittest.mock to patch stdin and replace it with a defined string so that the test suite can run without manual intervention, but the complexities of that operation eluded me. My working theory is that it will be necessary to use the pty module to control terminal operations programmatically, but that is beyond my level of expertise.