Skip to content

BUG | sendSettings for screenVideo are ignored in prebuilt increateFrame() calls #242

Open
@mklepaczewski

Description

@mklepaczewski

Expected behavior

createFrame() should set screenVideo settings.

Describe the bug (unexpected behavior)

Passing screenVideo encodings during DailyIframe.createFrame() call doesn't set the settings. Instead, following encoding is used:

{ encodings: { low: {dtx: true, maxBitrate: 2000000, scaleResolutionDownBy: 1, maxFramerate: 30} } }

Steps to reproduce

Use following snippet:

callFrame = DailyIframe.createFrame({
            sendSettings: {
                screenVideo: {
                    maxQuality: "low",
                    encodings: {
                        low:    { scaleResolutionDownBy: 10, maxFramerate: 2,  },
                    }
                }
            },
            iframeStyle: {
                position: "fixed",
                border: 0,
                top: 0,
                left: 0,
                width: "100%",
                height: "100%",
            }
        });

        callFrame.on(
            'send-settings-updated',
            function (event) {
                console.log("send-settings-updated", event);
            }
        );

        await callFrame.join({
            url: ROOM_URL,
            token: TOKEN
        });

Open dev console, notice that sendSettings are mostly ignored (see the screenshot)

Screenshots

image

System information

I'm using Daily 0.58.0, but I also tested it on versions I 100% know used to work, and the bug is there, too.

  • Device: PC
  • OS, version: Windows, 10
  • Browser, version: Chrome Version 121.0.6167.185 (Official Build) (64-bit)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions