Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double validation errors #718

Merged

Conversation

skwair
Copy link
Contributor

@skwair skwair commented Feb 3, 2025

Description

This PR fixes a regression introduced in #705, described in #717.

While hardening test cases, I noticed that slices of uint8s were not supported, so I took the liberty to also add the implementation (in a separate commit though, which can be reverted if this was intentional).

Fixes #717

Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielgtaylor danielgtaylor requested a review from Copilot February 4, 2025 01:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.86%. Comparing base (b2dfa81) to head (644be26).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
huma.go 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   92.90%   92.86%   -0.05%     
==========================================
  Files          22       22              
  Lines        4963     4976      +13     
==========================================
+ Hits         4611     4621      +10     
- Misses        305      308       +3     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielgtaylor danielgtaylor merged commit f9ffb6a into danielgtaylor:main Feb 4, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid boolean query parameters return two errors instead of one since 2.28.0
2 participants