LBAAS-3620: support load balancers network_stack #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasilevsky
force-pushed
the
jvasilevsky/LBAAS-3620-doctl
branch
from
a206d2c to
f118030
Compare
jvasilevsky
force-pushed
the
jvasilevsky/LBAAS-3620-doctl
branch
3 times, most recently
from
37c55a2 to
6d19080
Compare
jvasilevsky
force-pushed
the
jvasilevsky/LBAAS-3620-doctl
branch
from
6d19080 to
f8958e1
Compare
bbassingthwaite
approved these changes
Jan 28, 2025
bentranter
reviewed
Jan 28, 2025
commands/load_balancers.go
Outdated
| @@ -101,6 +101,8 @@ With the load-balancer command, you can list, create, or delete load balancers, | |||
| AddStringSliceFlag(cmdLoadBalancerCreate, doctl.ArgTargetLoadBalancerIDs, "", []string{}, | |||
| "A comma-separated list of Load Balancer IDs to add as target to the global load balancer ") | |||
| AddStringFlag(cmdLoadBalancerCreate, doctl.ArgLoadBalancerNetwork, "", "", "The type of network the load balancer is accessible from, e.g.: `EXTERNAL` or `INTERNAL`") | |||
| AddStringFlag(cmdLoadBalancerCreate, doctl.ArgLoadBalancerNetworkStack, "", "", "The network stack type determines the allocation of ipv4/ipv6 addresses to the load balancer, e.g.: `IPV4` or `DUALSTACK`"+ | |||
| " (NOTE: this is a closed beta feature, contact DigitalOcean support to review its public availability.)") | |||
There was a problem hiding this comment.
Should we use the updated product lifecycle language here?
Suggested change
| " (NOTE: this is a closed beta feature, contact DigitalOcean support to review its public availability.)") | |
| " (NOTE: this is feature is in private preview, contact DigitalOcean support to review its public availability.)") |
bentranter
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support load balancers network_stack