Adding proxy support for pagerDuty client #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
I'm trying to use this awesome pagerDuty client behind a corporate proxy and I'm having the same issue as described here: #12
This PR introduces the ability to specify a proxy configuration when creating a PagerDutyEvents client. An alternative solution I've considered was to make the Unirest HTTP client automatically pick up system proxy env variables, but that might impact people already using this lib. Also, there are multiple env variables used for setting proxies since there is some convention around them, but not a standard (e.g. $http_proxy, $http.proxyHost)
Please take a look when you have a chance, I'm happy to address any of your comments here.
Thanks,
Bogdan.