Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emit reaction type on gateway events #10598

Merged
merged 2 commits into from
Nov 18, 2024
Merged

feat: Emit reaction type on gateway events #10598

merged 2 commits into from
Nov 18, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 16, 2024

Please describe the changes this PR makes and why it should be merged:

type does not appear to be on the reaction object itself, so I've added it into MessageReactionEventDetails instead.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@Jiralite Jiralite requested a review from a team as a code owner November 16, 2024 16:11
Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 11:53am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 11:53am

@kodiakhq kodiakhq bot merged commit b03a9e4 into main Nov 18, 2024
25 checks passed
@kodiakhq kodiakhq bot deleted the feat/reaction-type branch November 18, 2024 11:58
Jiralite added a commit that referenced this pull request Nov 18, 2024
feat: emit reaction type

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants