Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FetchApplicationCommandOptions): Use Locale over LocaleString #10625

Merged
merged 2 commits into from
Nov 29, 2024
Merged

refactor(FetchApplicationCommandOptions): Use Locale over LocaleString #10625

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5069ffa
refactor(FetchApplicationCommandOptions): prefer `Locale`
Jiralite Nov 28, 2024
609f4ca
Merge branch 'main' into refactor/djs-locale
Jiralite Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/discord.js/src/managers/ApplicationCommandManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class ApplicationCommandManager extends CachedManager {
* Options used to fetch Application Commands from Discord
* @typedef {BaseFetchOptions} FetchApplicationCommandOptions
* @property {Snowflake} [guildId] The guild's id to fetch commands for, for when the guild is not cached
* @property {LocaleString} [locale] The locale to use when fetching this command
* @property {Locale} [locale] The locale to use when fetching this command
* @property {boolean} [withLocalizations] Whether to fetch all localization data
*/

Expand Down
5 changes: 0 additions & 5 deletions packages/discord.js/src/util/APITypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,11 +469,6 @@
* @see {@link https://discord-api-types.dev/api/discord-api-types-rest/common/enum/Locale}
*/

/**
* @external LocaleString
* @see {@link https://discord-api-types.dev/api/discord-api-types-rest/common#LocaleString}
*/

/**
* @external MessageActivityType
* @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/MessageActivityType}
Expand Down
3 changes: 1 addition & 2 deletions packages/discord.js/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ import {
APIEmbedImage,
VideoQualityMode,
LocalizationMap,
LocaleString,
MessageActivityType,
APIAttachment,
APIChannel,
Expand Down Expand Up @@ -5566,7 +5565,7 @@ export type EmojiResolvable = Snowflake | GuildEmoji | ReactionEmoji | Applicati

export interface FetchApplicationCommandOptions extends BaseFetchOptions {
guildId?: Snowflake;
locale?: LocaleString;
locale?: Locale;
withLocalizations?: boolean;
}

Expand Down