refactor(actions): removed unnecessary actions #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
force-pushed
the
refactor/remove-useless-actions
branch
2 times, most recently
from
cbbbd4d to
f123bee
Compare
SpaceEEC
approved these changes
Jan 12, 2025
Jiralite
approved these changes
Jan 13, 2025
vladfrangu
previously requested changes
Jan 13, 2025
packages/discord.js/src/client/websocket/handlers/AUTO_MODERATION_RULE_CREATE.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/client/websocket/handlers/AUTO_MODERATION_RULE_DELETE.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/client/websocket/handlers/AUTO_MODERATION_ACTION_EXECUTION.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/client/websocket/handlers/AUTO_MODERATION_RULE_UPDATE.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/client/websocket/handlers/PRESENCE_UPDATE.js
Outdated
Show resolved
Hide resolved
|
This needs a rebase too |
almeidx
force-pushed
the
refactor/remove-useless-actions
branch
from
fedc98d to
cf7aa53
Compare
Removed actions that were only being used in their respective websocket handlers. The remaining actions either were either being used elsewhere or were using methods from the `GenericAction` class. Co-authored-by: Vlad Frangu <[email protected]>
almeidx
force-pushed
the
refactor/remove-useless-actions
branch
from
cf7aa53 to
376a580
Compare
vladfrangu
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Removed actions that were only being used in their
respective websocket handlers. The remaining
actions either were either being used elsewhere or
were using methods from the
GenericActionclass.Status and versioning classification: