reset auto increment counter on dolt_reset('--hard')
#8319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
fulghum
approved these changes
Sep 3, 2024
| // AcquireTableLock acquires the auto increment lock on a table, and returns a callback function to release the lock. | ||
| // Depending on the value of the `innodb_autoinc_lock_mode` system variable, the engine may need to acquire and hold | ||
| // the lock for the duration of an insert statement. | ||
| AcquireTableLock(ctx *sql.Context, tableName string) (func(), error) | ||
| // InitWithRoots fills the AutoIncrementTracker with values at the specified root. |
There was a problem hiding this comment.
(minor) Might be helpful to explain the behavior when multiple roots are present – currently it sounds like it's only for one root. For example, telling the caller that auto_inc sequence values are pulled out of each root, in order, and initialized for every table in each root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
dolt_reset(--hard), we don't properly reload the auto increment value from the global tracker.The bug is a side effect from maintaining auto increment value between branches. We track the last greatest auto increment value across all branches in the session, and dropping a table sets the previous auto_increment value to 0.
The fix is to get the tracker to reload values when resetting.
Some notable behavior here is that a
dolt_resetover insert will not reset the auto_increment tracker.fixes: #8272