Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: sqle/binlogreplication: Add some waits for more reliable observations of IO_error results. #8809

Merged
merged 1 commit into from
Feb 5, 2025
Merged

go: sqle/binlogreplication: Add some waits for more reliable observations of IO_error results. #8809

merged 1 commit into from
Feb 5, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Feb 4, 2025

No description provided.

@reltuk reltuk requested a review from fulghum February 4, 2025 19:22
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6d95550 ok 5937457
version total_tests
6d95550 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit 5dece74 into main Feb 5, 2025
34 of 35 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reltuk @coffeegoddd @fulghum