fix insert for subquery aliases with on duplicate update expr #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Feb 20, 2025
| if values, ok := n.Source.(*plan.Values); ok { | ||
| // The source table is either named via VALUES(...) AS ... or has | ||
| // the default value planbuilder.OnDupValuesPrefix | ||
| destSch := n.Destination.Schema() |
There was a problem hiding this comment.
i've gone through line by line and i'm maybe missing if there was any logical change, correct me if i'm wrong
| continue | ||
| } | ||
| if i < len(srcScope.cols) { | ||
| combinedScope.newColumn(srcScope.cols[i]) |
There was a problem hiding this comment.
this is the only change? not putting the extra cols in combined scope?
added 2 commits
February 20, 2025 11:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
table not founderror was actually a bad error message; it really wasn't finding the column due to some weird logic around resolving duplicate indexes.The logic assumes that
n.Destination.Schema()andn.Source.Schema()must be equal length, and if it's not then we need to replace the Source columns' Source node with the providedOnDupValuesPrefix.Additionally, when assigning getfield indexes, we can't assume that if the schema lengths are mismatched that they must be using the
OnDupValuesPrefix. Instead, we should always search for a matching column, and then substitute.fixes: dolthub/dolt#8862