Fix resize handler positioning & add full screen by default in mail #356
Conversation
|
@RicSala is attempting to deploy a commit to the Inbox Zero Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update adjusts the layout and panel sizing in the EmailList component. A fixed height ( Changes
Sequence Diagram(s)sequenceDiagram
participant EL as EmailList
participant RG as ResizeGroup
participant RPP as ResizablePanelGroup
EL->>RG: Render with {left, right, onlyRight}
alt onlyRight is true
RG->>RPP: Set panel sizes (left: 0, right: 100)
else
RG->>RPP: Set panel sizes (left: 50, right: 50)
end
RG->>EL: Render layout with fixed height container
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
apps/web/components/email-list/EmailList.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@typescript-eslint/parser' declared in 'apps/web/.eslintrc.json': Cannot find module '@typescript-eslint/parser'
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request includes changes to the
EmailListcomponent in theapps/web/components/email-list/EmailList.tsxfile. The main focus of these changes is:Make full screen by default (keeping the handler of the resizable group)
Fix the positoning of the handler (it was being centered to the whole liste of emails instead of the ones in viewport, which made it not obvious). Now is centered.
Make the resizeable pannels to scroll independently
Comment: Had to set the height of the wrapper around ActionButtonsBulk explicitly. Otherwise the app layout managed the scroll instead.
Enhancements to EmailList component:
h-12for consistent sizing.onlyRightprop to theResizeGroupcomponent to control the visibility and size of the left and right panels based on whether a thread is open. [1] [2]ResizeGroupcomponent to dynamically set the sizes of the left and right panels, ensuring that the right panel takes up the full width whenonlyRightis true.Summary by CodeRabbit
New Features
Style