Skip to content

Commit

Permalink
Add bigdecimal to dependencies in preparation for Ruby 3.4 where it i…
Browse files Browse the repository at this point in the history
…s no longer built in.
  • Loading branch information
JasonLunn committed Apr 2, 2024
1 parent 063c198 commit 084063b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions ruby/google-protobuf.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Gem::Specification.new do |s|
s.add_development_dependency "rake-compiler-dock", "= 1.2.1"
end
s.required_ruby_version = '>= 3.0'
# bigdecimal must be used as a non-built in gem as of ruby-3.4
s.add_dependency "bigdecimal"
# TODO: evaluate removing Rakefile and moving logic to extconf.rb, so that we
# can remove this runtime dependency on rake. See the discussion here for
# more details:
Expand Down
5 changes: 4 additions & 1 deletion ruby/lib/google/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ ruby_library(
"ruby/lib",
],
visibility = ["//ruby:__pkg__"],
deps = ["//ruby:well_known_ruby_protos"] + select({
deps = [
"//ruby:well_known_ruby_protos",
"@protobuf_bundle//:bigdecimal",
] + select({
"//ruby:ffi_enabled": [
"@protobuf_bundle//:ffi",
"@protobuf_bundle//:ffi-compiler",
Expand Down

0 comments on commit 084063b

Please sign in to comment.