Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes postpack script to cleanup correct file type #1111

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

scalvert
Copy link
Contributor

Fixes bug in postpack that incorrectly deletes .ts files rather than .js.

@scalvert scalvert added the bug label Aug 23, 2021
@scalvert scalvert requested a review from stefanpenner August 23, 2021 19:32
@@ -24,7 +24,7 @@
},
"scripts": {
"prepack": "yarn babel --extensions '.ts' --presets @babel/preset-typescript addon-test-support --out-dir addon-test-support/ --ignore '**/*.d.ts'",
"postpack": "rimraf addon-test-support/**/*.ts",
"postpack": "rimraf addon-test-support/**/*.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, i got this backwards, thank you!

@stefanpenner stefanpenner merged commit 170d554 into master Aug 23, 2021
@stefanpenner stefanpenner deleted the fix-prepack branch August 23, 2021 23:06
@rwjblue rwjblue added internal and removed bug labels Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants