Add moduleForIntegration #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,17 +1,16 @@ | |||
| import Ember from 'ember'; | |||
| import hasEmberVersion from 'ember-test-helpers/has-ember-version'; | |||
| import { TestModuleForComponent } from 'ember-test-helpers'; | |||
| import { TestModuleForIntegration } from 'ember-test-helpers'; | |||
| import test from 'tests/test-support/qunit-test'; | |||
| import qunitModuleFor from 'tests/test-support/qunit-module-for'; | |||
| import { setResolverRegistry } from 'tests/test-support/resolver'; | |||
|
|
|||
| function moduleForComponent(name, description, callbacks) { | |||
There was a problem hiding this comment.
Change this to moduleForIntegration for clarity.
captain-enjoyable
force-pushed
the
module-for-integration
branch
3 times, most recently
from
8b22bec to
595c0b4
Compare
captain-enjoyable
force-pushed
the
module-for-integration
branch
from
a11e8ba to
c52bdfa
Compare
|
This looks good to me. I'm happy to land this and iterate. @mmun r? |
|
@rwjblue r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves component integration testing behavior into its own module named (unsurprisingly 😄)
TestModuleForIntegration. This new module now depends onAbstractTestModuleinstead ofTestModulethus removing boilerplate. Additionally, the new module doesn't contain behavior associated with 'legacy' and unit tests.