Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set resolver when setApplication is called. #242

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Nov 11, 2017

This allows an application to call:

setApplication(App.create({ autoboot: false }));

And still support legacy style moduleFor* tests.

Without this change the following both of the following invocations are required:

setApplication(App.create({ autoboot: false }));
setResolver(resolver);

This allows an application to call:

```js
setApplication(App.create({ autoboot: false }));
```

And still support legacy style `moduleFor*` tests.

Without this change the following both of the following invocations are
required:

```js
setApplication(App.create({ autoboot: false }));
setResolver(resolver);
```
@rwjblue rwjblue merged commit 933dea1 into emberjs:master Nov 11, 2017
@rwjblue rwjblue deleted the infer-resolver-when-application-is-set branch November 11, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant