Fix regression with wait() timeouts.
#319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Feb 12, 2018
rwjblue
force-pushed
the
fix-wait-regression
branch
from
00233d0 to
617ee44
Compare
When `wait` was split from `settled` I forgot to also include an infinite timeout (preventing tests from failing that take longer than 2s).
rwjblue
force-pushed
the
fix-wait-regression
branch
from
617ee44 to
bc6909d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
waitwas split fromsettledI forgot to also include an infinite timeout (preventing tests from failing that take longer than 2s).Fixes #318