Skip to content

Fresh Ember addon indirectly depends on core-js@2 #20818

Open
@paddor

Description

🐞 Describe the Bug

I've noticed that even a freshly initialized Ember 5.12.0 addon depends on [email protected], which is deprecated. This seems to happen because:

$ pnpm why -r [email protected] --long
[...]
dependencies:
ember-auto-import 2.10.0
│ Zero-config import from NPM packages
│ git+https://github.com/embroider-build/ember-auto-import.git
│ https://github.com/embroider-build/ember-auto-import#readme
│ /home/user/dev/node_modules/.pnpm/[email protected][email protected]/node_modules/ember-auto-import
└─┬ @embroider/macros 1.16.10
  │ Standardized build-time macros for ember apps.
  │ git+https://github.com/embroider-build/embroider.git
  │ https://github.com/embroider-build/embroider#readme
  │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@embroider/macros
  └─┬ ember-cli-babel 7.26.11
    │ Ember CLI addon for Babel
    │ git://github.com/babel/ember-cli-babel.git
    │ https://github.com/babel/ember-cli-babel
    │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/ember-cli-babel
    ├─┬ @babel/polyfill 7.12.1
    │ │ Provides polyfills necessary for a full ES2015+ environment
    │ │ git+https://github.com/babel/babel.git
    │ │ https://babeljs.io/
    │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
    │ └── core-js 2.6.12
    │     Standard library
    │     git+https://github.com/zloirock/core-js.git
    │     https://github.com/zloirock/core-js#readme
    │     /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
    └─┬ broccoli-babel-transpiler 7.8.1
      │ A Broccoli plugin which transpile ES6 to readable ES5 by using babel.
      │ git+https://github.com/babel/broccoli-babel-transpiler.git
      │ https://github.com/babel/broccoli-babel-transpiler
      │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/broccoli-babel-transpiler
      └─┬ @babel/polyfill 7.12.1
        │ Provides polyfills necessary for a full ES2015+ environment
        │ git+https://github.com/babel/babel.git
        │ https://babeljs.io/
        │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
        └── core-js 2.6.12
            Standard library
            git+https://github.com/zloirock/core-js.git
            https://github.com/zloirock/core-js#readme
            /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
ember-data 5.3.9
│ The lightweight reactive data library for JavaScript applications
│ git+ssh://[email protected]/emberjs/data.git
│ https://github.com/emberjs/data#readme
│ /home/user/dev/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected]_@glimmer+co_z6d4xcpwkhsmj4msy2joek3nhy/node_modules/ember-data
└─┬ @ember-data/adapter 5.3.9
  │ Provides Legacy JSON:API and REST Implementations of the Adapter Interface for use with @ember-data/store
  │ git+ssh://[email protected]/emberjs/data.git
  │ https://github.com/emberjs/data#readme
  │ /home/user/dev/node_modules/.pnpm/@[email protected]_@[email protected]_t2rxkbrt4crzotbgvggrkxun4i__@ember-_45ghzi4l7aenlnsfi7fr7ir7vu/node_modules/@ember-data/adapter
  └─┬ @ember-data/legacy-compat 5.3.9 peer
    │ Compatibility Shims for Older EmberData
    │ git+ssh://[email protected]/emberjs/data.git
    │ https://github.com/emberjs/data
    │ /home/user/dev/node_modules/.pnpm/@[email protected]_t2rxkbrt4crzotbgvggrkxun4i/node_modules/@ember-data/legacy-compat
    └─┬ @ember-data/request 5.3.9 peer
      │ ⚡️ A simple, small and fast framework-agnostic library to make `fetch` happen
      │ git+ssh://[email protected]/emberjs/data.git
      │ https://github.com/emberjs/data
      │ /home/user/dev/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@ember-data/request
      ├─┬ @ember/test-waiters 3.1.0
      │ │ Allow tests to be aware of addon / application asynchrony.
      │ │ git+https://github.com/emberjs/ember-test-waiters.git
      │ │ https://github.com/emberjs/ember-test-waiters#readme
      │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@ember/test-waiters
      │ └─┬ ember-cli-babel 7.26.11
      │   │ Ember CLI addon for Babel
      │   │ git://github.com/babel/ember-cli-babel.git
      │   │ https://github.com/babel/ember-cli-babel
      │   │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/ember-cli-babel
      │   ├─┬ @babel/polyfill 7.12.1
      │   │ │ Provides polyfills necessary for a full ES2015+ environment
      │   │ │ git+https://github.com/babel/babel.git
      │   │ │ https://babeljs.io/
      │   │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
      │   │ └── core-js 2.6.12
      │   │     Standard library
      │   │     git+https://github.com/zloirock/core-js.git
      │   │     https://github.com/zloirock/core-js#readme
      │   │     /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
      │   └─┬ broccoli-babel-transpiler 7.8.1
      │     │ A Broccoli plugin which transpile ES6 to readable ES5 by using babel.
      │     │ git+https://github.com/babel/broccoli-babel-transpiler.git
      │     │ https://github.com/babel/broccoli-babel-transpiler
      │     │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/broccoli-babel-transpiler
      │     └─┬ @babel/polyfill 7.12.1
      │       │ Provides polyfills necessary for a full ES2015+ environment
      │       │ git+https://github.com/babel/babel.git
      │       │ https://babeljs.io/
      │       │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
      │       └── core-js 2.6.12
      │           Standard library
      │           git+https://github.com/zloirock/core-js.git
      │           https://github.com/zloirock/core-js#readme
      │           /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
      ├─┬ @embroider/macros 1.16.10
      │ │ Standardized build-time macros for ember apps.
      │ │ git+https://github.com/embroider-build/embroider.git
      │ │ https://github.com/embroider-build/embroider#readme
      │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@embroider/macros
      │ └─┬ ember-cli-babel 7.26.11
      │   │ Ember CLI addon for Babel
      │   │ git://github.com/babel/ember-cli-babel.git
      │   │ https://github.com/babel/ember-cli-babel
      │   │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/ember-cli-babel
      │   ├─┬ @babel/polyfill 7.12.1
      │   │ │ Provides polyfills necessary for a full ES2015+ environment
      │   │ │ git+https://github.com/babel/babel.git
      │   │ │ https://babeljs.io/
      │   │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
      │   │ └── core-js 2.6.12
      │   │     Standard library
      │   │     git+https://github.com/zloirock/core-js.git
      │   │     https://github.com/zloirock/core-js#readme
      │   │     /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
      │   └─┬ broccoli-babel-transpiler 7.8.1
      │     │ A Broccoli plugin which transpile ES6 to readable ES5 by using babel.
      │     │ git+https://github.com/babel/broccoli-babel-transpiler.git
      │     │ https://github.com/babel/broccoli-babel-transpiler
      │     │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/broccoli-babel-transpiler
      │     └─┬ @babel/polyfill 7.12.1
      │       │ Provides polyfills necessary for a full ES2015+ environment
      │       │ git+https://github.com/babel/babel.git
      │       │ https://babeljs.io/
      │       │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
      │       └── core-js 2.6.12
      │           Standard library
      │           git+https://github.com/zloirock/core-js.git
      │           https://github.com/zloirock/core-js#readme
      │           /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
      ├─┬ @warp-drive/build-config 0.0.0-beta.7
      │ │ Provides Build Configuration for projects using WarpDrive or EmberData
      │ │ git+ssh://[email protected]/emberjs/data.git
      │ │ https://github.com/emberjs/data#readme
      │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@warp-drive/build-config
      │ └─┬ @embroider/macros 1.16.10
      │   │ Standardized build-time macros for ember apps.
      │   │ git+https://github.com/embroider-build/embroider.git
      │   │ https://github.com/embroider-build/embroider#readme
      │   │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@embroider/macros
      │   └─┬ ember-cli-babel 7.26.11
      │     │ Ember CLI addon for Babel
      │     │ git://github.com/babel/ember-cli-babel.git
      │     │ https://github.com/babel/ember-cli-babel
      │     │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/ember-cli-babel
      │     ├─┬ @babel/polyfill 7.12.1
      │     │ │ Provides polyfills necessary for a full ES2015+ environment
      │     │ │ git+https://github.com/babel/babel.git
      │     │ │ https://babeljs.io/
      │     │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
      │     │ └── core-js 2.6.12
      │     │     Standard library
      │     │     git+https://github.com/zloirock/core-js.git
      │     │     https://github.com/zloirock/core-js#readme
      │     │     /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
      │     └─┬ broccoli-babel-transpiler 7.8.1
      │       │ A Broccoli plugin which transpile ES6 to readable ES5 by using babel.
      │       │ git+https://github.com/babel/broccoli-babel-transpiler.git
      │       │ https://github.com/babel/broccoli-babel-transpiler
      │       │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/broccoli-babel-transpiler
      │       └─┬ @babel/polyfill 7.12.1
      │         │ Provides polyfills necessary for a full ES2015+ environment
      │         │ git+https://github.com/babel/babel.git
      │         │ https://babeljs.io/
      │         │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
      │         └── core-js 2.6.12
      │             Standard library
      │             git+https://github.com/zloirock/core-js.git
      │             https://github.com/zloirock/core-js#readme
      │             /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
      └─┬ @warp-drive/core-types 0.0.0-beta.12 peer
        │ Provides core logic, utils and types for WarpDrive and EmberData
        │ git+ssh://[email protected]/emberjs/data.git
        │ https://github.com/emberjs/data#readme
        │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@warp-drive/core-types
        └─┬ @embroider/macros 1.16.10
          │ Standardized build-time macros for ember apps.
          │ git+https://github.com/embroider-build/embroider.git
          │ https://github.com/embroider-build/embroider#readme
          │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@embroider/macros
          └─┬ ember-cli-babel 7.26.11
            │ Ember CLI addon for Babel
            │ git://github.com/babel/ember-cli-babel.git
            │ https://github.com/babel/ember-cli-babel
            │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/ember-cli-babel
            ├─┬ @babel/polyfill 7.12.1
            │ │ Provides polyfills necessary for a full ES2015+ environment
            │ │ git+https://github.com/babel/babel.git
            │ │ https://babeljs.io/
            │ │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
            │ └── core-js 2.6.12
            │     Standard library
            │     git+https://github.com/zloirock/core-js.git
            │     https://github.com/zloirock/core-js#readme
            │     /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js
            └─┬ broccoli-babel-transpiler 7.8.1
              │ A Broccoli plugin which transpile ES6 to readable ES5 by using babel.
              │ git+https://github.com/babel/broccoli-babel-transpiler.git
              │ https://github.com/babel/broccoli-babel-transpiler
              │ /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/broccoli-babel-transpiler
              └─┬ @babel/polyfill 7.12.1
                │ Provides polyfills necessary for a full ES2015+ environment
                │ git+https://github.com/babel/babel.git
                │ https://babeljs.io/
                │ /home/user/dev/node_modules/.pnpm/@[email protected]/node_modules/@babel/polyfill
                └── core-js 2.6.12
                    Standard library
                    git+https://github.com/zloirock/core-js.git
                    https://github.com/zloirock/core-js#readme
                    /home/user/dev/node_modules/.pnpm/[email protected]/node_modules/core-js

🔬 Minimal Reproduction

ember addon my-app-webui-addon --skip-git --skip-npm

😕 Actual Behavior

Deprecated packages are in the dependencies.

🤔 Expected Behavior

I expect non-deprecated packages are in the dependencies.

🌍 Environment

  • Ember-CLI: 5.12.0
  • Node.js/npm: v22.12.0 lts/jod
  • OS: Ubuntu 22.04

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions