Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Deployment manifest generation issue (#631) #632

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: Fix Deployment manifest generation issue (#631) #632

merged 1 commit into from
Feb 18, 2025

Conversation

daniil-nedostup
Copy link
Contributor

@daniil-nedostup daniil-nedostup commented Feb 18, 2025 •
edited
Loading

Pull Request

Description

Fix Deployment manifest generation issue when config.oidc.enabled flag is set to false.

Fixes #631

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@daniil-nedostup daniil-nedostup requested a review from a team as a code owner February 18, 2025 10:33
@daniil-nedostup daniil-nedostup self-assigned this Feb 18, 2025
@daniil-nedostup daniil-nedostup added the enhancement New feature or request label Feb 18, 2025
@MykolaMarusenko MykolaMarusenko merged commit a5a709d into master Feb 18, 2025
6 checks passed
@MykolaMarusenko MykolaMarusenko deleted the EPMDEDP-15006 branch February 18, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MykolaMarusenko MykolaMarusenko MykolaMarusenko approved these changes

Assignees

@daniil-nedostup daniil-nedostup

Labels
enhancement New feature or request
Projects
KubeRocketCI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Deployment Manifest Generation Issue
2 participants
@daniil-nedostup @MykolaMarusenko