revise commits not being made with external editor

[scotho3]

I'm using sublime text with it's hand subl in my bin, and composure opens the file just fine, but when it's saved in my editor, and I head back to the terminal, I enter the commit message, but never actually commits the changes. A subsequent revise script opens the original. Is something else required besides simply setting up my $EDITOR ?

[erichs]

Interesting. What version of Sublime Text are you using? Can you please share the following:

echo $EDITOR
$SHELL --version

[scotho3]

Sublime Text - Stable Channel, Build 3065

$ echo $EDITOR
subl 
$ $SHELL --version
GNU bash, version 3.2.53(1)-release (x86_64-apple-darwin14)
Copyright (C) 2007 Free Software Foundation, Inc.

Also, when I revise, it automatically is waiting for the commit message, even before the file is saved in subl.

[erichs]

Ok. I think what is happening here is that command-line sublime needs to be started as subl -w, where the -w flag means "wait for the files to be closed before returning". Unfortunately, you may find that

export EDITOR="subl -w"

does not work for you. If you export the above and see "command not found" errors, I would ask you to please create a small script, say /usr/local/bin/sublw:

#!/bin/bash
/usr/local/bin/subl -w $*

Then, do:

chmod +x /usr/local/bin/sublw

Finally, do:

export EDITOR=sublw

The alternative, in order to support EDITOR flags within composure, would likely involve the use of eval, which I would rather strongly seek to avoid in this context. Please let me know if the workaround above works for you!

[scotho3]

adding the -w flag worked perfectly! Thanks.